Support event APIs #339
Support event APIs #339
Conversation
jkrvivian
force-pushed
the
feat/inx-mqtt
branch
from
c0cceee to
ba76a8d
Compare
components/inx/server_utxo.go
Outdated
| func (s *Server) ReadOutputMetadata(_ context.Context, id *inx.OutputId) (*inx.OutputMetadata, error) { | ||
| outputID := id.Unwrap() | ||
|
|
||
| output, spent, err := deps.Protocol.MainEngineInstance().Ledger.OutputOrSpent(outputID) |
There was a problem hiding this comment.
Mhh so we don't have any info about the latest commitment in the Ledger?
Because between fetching the output from the ledger, and reading the latestCommitment from the SyncManager.... there could be a change. We need this info atomically.
Otherwise we return the wrong latestCommitmentId.
There was a problem hiding this comment.
No, we only have it in Storage and SyncManager. 🤔
There was a problem hiding this comment.
The ledgerstate has the index, but when we read this we go through the mempool which has a potentially newer state than the ledgerstate. That is why it is important to compare the slot indexes in the output metadata with the latest commitment of the node, that way you will see if the output was committed or if it is still just in the mempool
Changes are also made in:
inx-mqttdocker image can be packed and successfully tested in docker-network.Close #227